Re: [HACKERS] pgbench - allow to store select results into variables

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] pgbench - allow to store select results into variables
Date: 2018-08-13 22:30:55
Message-ID: alpine.DEB.2.21.1808140012360.2727@lancre
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


Hello Andrew,

>> Attached is v18, another basic rebase after some perl automatic
>> reindentation.
>
> This patch contains CRLF line endings

Alas, not according to "file" nor "hexdump" (only 0A, no 0D) on my local
version, AFAICS.

What happens on the path and what is done by mail clients depending on the
mime type is another question (eg text/x-diff or text/plain).

> - and in any case it doesn't apply any more. Please fix those things.

Here is the new generated version, v19, that I just tested on my linux
ubuntu bionic laptop:

sh> git checkout -b test master
Switched to a new branch 'test'

sh> cksum ~/pgbench-into-19.patch
3375461661 26024 ~/pgbench-into-19.patch

sh> hexdump ~/pgbench-into-19.patch
0000000 6964 6666 2d20 672d 7469 6120 642f 636f
0000010 732f 6372 732f 6d67 2f6c 6572 2f66 6770
0000020 6562 636e 2e68 6773 6c6d 6220 642f 636f
0000030 732f 6372 732f 6d67 2f6c 6572 2f66 6770
0000040 6562 636e 2e68 6773 6c6d 690a 646e ....
# no 0d in front of 0a ^^

sh> git apply ~/pgbench-into-19.patch

sh> git status
On branch test ...
modified: doc/src/sgml/ref/pgbench.sgml
modified: src/bin/pgbench/pgbench.c
modified: src/bin/pgbench/pgbench.h
modified: src/bin/pgbench/t/001_pgbench_with_server.pl
modified: src/fe_utils/psqlscan.l
modified: src/include/fe_utils/psqlscan_int.h

--
Fabien.

Attachment Content-Type Size
pgbench-into-19.patch text/plain 26.2 KB
pgbench-into-19.patch.gz application/gzip 7.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2018-08-13 23:13:04 Pre-v11 appearances of the word "procedure" in v11 docs
Previous Message Tom Lane 2018-08-13 22:27:03 Re: libpq should append auth failures, not overwrite