Re: [HACKERS] pgbench - allow to store select results into variables

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] pgbench - allow to store select results into variables
Date: 2018-08-14 10:47:43
Message-ID: 527f7e3e-402f-4043-b370-2e11ca84d19e@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08/13/2018 06:30 PM, Fabien COELHO wrote:
>
> Hello Andrew,
>
>>> Attached is v18, another basic rebase after some perl automatic
>>> reindentation.
>>
>> This patch contains CRLF line endings
>
> Alas, not according to "file" nor "hexdump" (only 0A, no 0D) on my
> local version, AFAICS.
>
> What happens on the path and what is done by mail clients depending on
> the mime type is another question (eg text/x-diff or text/plain).

It's not done by my MUA, and it's present in your latest posted patch.
If anything I'd suspect your MUA:

andrew(at)emma*$ curl -s
https://www.postgresql.org/message-id/attachment/64237/pgbench-into-19.patch
| head -n 3 | od -c
0000000   d   i   f   f       -   -   g   i   t       a   /   d o   c
0000020   /   s   r   c   /   s   g   m   l   /   r   e   f   / p   g
0000040   b   e   n   c   h   .   s   g   m   l       b   /   d o   c
0000060   /   s   r   c   /   s   g   m   l   /   r   e   f   / p   g
0000100   b   e   n   c   h   .   s   g   m   l  \r  \n   i   n d   e
0000120   x       8   8   c   f   8   b   3   9   3   3   .   . 9   4
0000140   6   f   0   8   0   0   5   d       1   0   0   6   4   4 \r
0000160  \n   -   -   -       a   /   d   o   c   /   s   r   c /   s
0000200   g   m   l   /   r   e   f   /   p   g   b   e   n   c h   .
0000220   s   g   m   l  \r  \n

The gzipped version you also attached did not have the CRs.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2018-08-14 11:11:03 Re: Uncaught PHP Exception Doctrine\DBAL\Exception\UniqueConstraintViolationException: "An exception occurred while executing 'UPDATE
Previous Message Geoff Winkless 2018-08-14 10:32:56 Re: NetBSD vs libxml2