Re: csv format for psql

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Daniel Verite <daniel(at)manitou-mail(dot)org>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Isaac Morland <isaac(dot)morland(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: csv format for psql
Date: 2018-08-10 13:32:08
Message-ID: alpine.DEB.2.21.1808101351420.9120@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Daniel,

> PFA an updated version.
> Usage from the command line:
> $ psql --csv # or -P format=csv
> $ psql --csv -P fieldsep_csv=";" # for non-comma csv separator
> From inside psql:
> \pset format csv
> \pset fieldsep_csv '\t'

Patch applies cleanly, compiles, global make check ok.

Doc: "according to the csv rules" -> "according to csv rules."?

Doc: "RFC-4180" -> "RFC 4180"?

The previous RFC specifies CRLF as eol, but '\n' is hardcoded in the
source. I'm fine with that, but I'd suggest that the documentation should
said which EOL is used.

ISTM that "--csv" & "-C" are not documented, neither in sgml nor under

"fieldsep_csv" does not show on the list of output options under "\?".

There seems to be a test in the code to set an empty string "" by default,
but it is unclear to me when this is triggered.

I'd tend to use "CSV" instead of "csv" everywhere it makes sense, eg in
the doc (CSV rules) and in variable names in the code (FooCsv -> FooCSV?),
but that is pretty debatable.


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Marina Polyakova 2018-08-10 13:46:04 Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors
Previous Message Arthur Zakirov 2018-08-10 12:53:29 Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors