Re: pgbench's expression parsing & negative numbers

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgbench's expression parsing & negative numbers
Date: 2018-08-10 08:24:29
Message-ID: alpine.DEB.2.21.1808101018080.9120@lancre
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


Hello,

> The following review has been posted through the commitfest application:
> make installcheck-world: not tested
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: not tested
>
> Patch does not apply cleanly on the master branch, anyways I managed that. Patch work according to specs, and no issue found.
> The only minor nit is that you can keep the full comments of function strtoint64
>
> /*
> * If not errorOK, an error message is printed out.
> * If errorOK is true, just return "false" for bad input.
> */

Thanks for the review.

Attached is a v4, with improved comments on strtoint64 as you requested.
I also added 2 "unlikely" compiler directives.

--
Fabien.

Attachment Content-Type Size
pgbench-overflow-4.patch text/plain 14.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2018-08-10 08:33:37 Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors
Previous Message Kyotaro HORIGUCHI 2018-08-10 06:21:31 NLS handling fixes.