Re: pgbench's expression parsing & negative numbers

From: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Fabien Coelho <postgresql(dot)org(at)coelho(dot)net>
Subject: Re: pgbench's expression parsing & negative numbers
Date: 2018-08-08 10:58:43
Message-ID: 153372592352.1562.15615970772659300837.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: not tested

Patch does not apply cleanly on the master branch, anyways I managed that. Patch work according to specs, and no issue found.
The only minor nit is that you can keep the full comments of function strtoint64

/*
* If not errorOK, an error message is printed out.
* If errorOK is true, just return "false" for bad input.
*/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-08-08 11:21:16 Re: partition tree inspection functions
Previous Message KES 2018-08-08 10:55:53 Re: Typo in doc or wrong EXCLUDE implementation