| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru>, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Subject: | Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors |
| Date: | 2018-08-07 16:21:57 |
| Message-ID: | alpine.DEB.2.21.1808071814380.13466@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Marina,
> v10-0001-Pgbench-errors-use-the-RandomState-structure-for.patch
> - a patch for the RandomState structure (this is used to reset a client's
> random seed during the repeating of transactions after serialization/deadlock
> failures).
About this v10 part 1:
Patch applies cleanly, compile, global & local make check both ok.
The random state is cleanly separated so that it will be easy to reset it
on client error handling ISTM that the pgbench side is deterministic with
the separation of the seeds for different uses.
Code is clean, comments are clear.
I'm wondering what is the rational for the "xseed" field name? In
particular, what does the "x" stands for?
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-08-07 16:29:15 | Re: [PATCH] Include application_name in "connection authorized" log message |
| Previous Message | Alvaro Herrera | 2018-08-07 16:19:13 | Re: Page freezing, FSM, and WAL replay |