| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
| Cc: | Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: doc - add missing documentation for "acldefault" |
| Date: | 2018-08-03 10:22:05 |
| Message-ID: | alpine.DEB.2.21.1808031208310.8068@lancre |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>> postgres=# \df acl*
>> List of fun
>> Schema | Name | Result data type |
>> ------------+-------------+------------------+----------------------------------
>> pg_catalog | aclcontains | boolean | aclitem[], aclitem
>> pg_catalog | acldefault | aclitem[] | "char", oid
>> pg_catalog | aclexplode | SETOF record | acl aclitem[], OUT grantor
>> oid, O
>> pg_catalog | aclinsert | aclitem[] | aclitem[], aclitem
>> pg_catalog | aclitemeq | boolean | aclitem, aclitem
>> pg_catalog | aclitemin | aclitem | cstring
>> pg_catalog | aclitemout | cstring | aclitem
>> pg_catalog | aclremove | aclitem[] | aclitem[], aclitem
>
> Some of them are definitely internal. For example, aclitemin and
> aclitemout are input and output functions respectively of the aclitem
> data type. I think they don't need to be documented and shouldn't have
> "pg_" prefix as they was created to maintenance aclitem data type.
Indeed, some are internal for managing the type itself. Maybe that
encompasses also "aclitemeq", not sure. I would see no harm in having them
documented though.
ISTM that acl{contains,default,explode,insert,remove} deserve a real doc.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-08-03 12:31:15 | Re: Alter index rename concurrently to |
| Previous Message | Adrien NAYRAT | 2018-08-03 09:43:31 | Re: Explain buffers wrong counter with parallel plans |