Re: [PATCH] pgbench - refactor some connection finish/null into common function

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: "Rady, Doug" <radydoug(at)amazon(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] pgbench - refactor some connection finish/null into common function
Date: 2018-01-30 11:41:49
Message-ID: alpine.DEB.2.20.1801301233220.22080@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Doug,

> This patch refactors all of the connection state PQfinish() and NULL’ing into a single function.
> Excludes PQfinish() in doConnect().

My 0.02€:

The argument could be "PGconn **" instead of a "CState *"?
If so, it may be used in a few more places. What is your opinion?

I'm fine with this kind of factorization which takes out a three-line
pattern, but I'm wondering whether it would please committers.

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2018-01-30 11:43:57 Re: [HACKERS] path toward faster partition pruning
Previous Message Oliver Ford 2018-01-30 10:48:16 Re: Add RANGE with values and exclusions clauses to the Window Functions