| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Improve scripting language in pgbench |
| Date: | 2018-01-10 12:36:24 |
| Message-ID: | alpine.DEB.2.20.1801101156070.2283@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hello Teodor,
I just noticed while rebasing stuff that there is some crust in
"pgbench/t/001_pgbench_with_server.pl" coming from this patch:
+=head
+
+} });
+
+=cut
I cannot find any use for these lines which are ignored by perl execution
anyway. It may be some leftovers from debugging which got past everyone.
If so, I think that it is better removed, see the attached cleanup patch.
--
Fabien.
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-tap-test-typo.patch | text/x-diff | 392 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-01-10 14:28:52 | pgsql: Give more accurate error message for dropping pinned portal |
| Previous Message | Teodor Sigaev | 2018-01-10 08:36:26 | Re: pgsql: Improve scripting language in pgbench |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | legrand legrand | 2018-01-10 13:02:21 | Re: AS OF queries |
| Previous Message | Fabien COELHO | 2018-01-10 12:27:19 | Re: Re: [HACKERS] pgbench randomness initialization |