| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: pgbench stuck with 100% cpu usage |
| Date: | 2017-09-29 18:22:46 |
| Message-ID: | alpine.DEB.2.20.1709292016400.4754@lancre |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Committed and back-patched to v10. I have to say I'm kind of
> surprised that the comment removed by this patch got committed in the
> first place. It's got a ??? in it and isn't very grammatical either.
ISTM that I reviewed the initial patch.
AFAICR I agreed with the comment that whether it was appropriate to go on
was unclear, but it did not strike me as obviously a bad idea at the time,
so I let it pass. Now it does strike me as a bad idea (tm):-) My English
is kind of fuzzy, so I tend not to comment too much on English unless I'm
really sure that it is wrong.
Note that there is another 100% cpu pgbench bug, see
https://commitfest.postgresql.org/15/1292/, which seems more likely to
occur in the wild that this one, but there has been no review of the fix I
sent.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2017-09-29 18:37:05 | Re: pgbench stuck with 100% cpu usage |
| Previous Message | Alexander Korotkov | 2017-09-29 18:17:54 | Re: [PATCH]make pg_rewind to not copy useless WAL files |