Re: pgbench regression test failure

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: pgbench regression test failure
Date: 2017-09-12 17:08:31
Message-ID: alpine.DEB.2.20.1709121850280.30961@lancre
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


> francolin just showed a non-reproducing failure in the new pgbench tests:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=francolin&dt=2017-09-12%2014%3A00%3A02

> not ok 211 - transaction count for 001_pgbench_log_1.31583 (3)

> # Failed test 'transaction count for 001_pgbench_log_1.31583 (3)'
> # at t/001_pgbench_with_server.pl line 438.
>
> Apparently, one of the threads ran 3 transactions where the test script
> expects it to run at most 2. Is this a pgbench bug, or is the test
> being overoptimistic about how exact the "-T 2" cutoff is?

Probably both? It seems that cutting off on time is not a precise science,
so I suggest to accept 1, 2 and 3 lines, see attached.

--
Fabien.

Attachment Content-Type Size
pgbench-tap-fix-3.patch text/x-diff 610 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Konstantin Knizhnik 2017-09-12 17:11:27 Re: Cached plans and statement generalization
Previous Message Tom Lane 2017-09-12 16:59:20 Re: [PATCH] Add citext_pattern_ops to citext contrib module