Re: pgsql: Fix more portability issues in new pgbench TAP tests.

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix more portability issues in new pgbench TAP tests.
Date: 2017-09-08 18:12:44
Message-ID: alpine.DEB.2.20.1709082010000.3568@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


> Fix more portability issues in new pgbench TAP tests.

Sorry for all these issues unforeseen issues. Thanks to the farm!

> * Remove no-such-user test case, output isn't stable, and we really
> don't need to be testing such cases here anyway.

Ok.

> * Fix the process exit code test logic to match PostgresNode::psql
> (but I didn't bother with looking at the "core" flag).

Ok. At least it is consistent.

> * Give up on inf/nan tests.

Too bad, I liked them!

Thanks for the fixes.

--
Fabien.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-09-08 18:39:17 pgsql: Remove mention of password_encryption = plain in postgresql.conf
Previous Message Tom Lane 2017-09-08 18:01:56 pgsql: Fix more portability issues in new pgbench TAP tests.