Re: pgbench: Skipping the creating primary keys after initialization

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench: Skipping the creating primary keys after initialization
Date: 2017-09-06 07:01:14
Message-ID: alpine.DEB.2.20.1709060853360.17848@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Applies, compiles, works for me.

Very very minor comments that I should have noticed before, sorry for this
additional round trip.

In the help line, move -I just after -i, to put short options in
alphabetical and decreasing importance order. On this line, also add the
information about the default, something like:

-i, --ini... ....
-I, --custom....=[...]+ (default "ctgvp")
...

When/if the pgbench tap test patch get through, the feature should be
tested there as well. No action needed now.

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-09-06 07:03:40 Changing Jobs
Previous Message Tatsuro Yamada 2017-09-06 06:58:26 Re: CLUSTER command progress monitor