From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: proposal: psql command \graw |
Date: | 2017-08-24 06:53:10 |
Message-ID: | alpine.DEB.2.20.1708240849080.2606@lancre |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>> "column_header" is somehow redundant with "tuples_only". Use the
>> existing one instead of adding a new one?
>
> It is different - a result of tuples_only is just tuples - not column
> names, not title, footer. I needed new special flag for enhancing
> tuples_only to print column names
I do not understand. If you keep the special print_raw function, it can
use tuples_only as true for without column names, and false for with
column names?
>> More generally, ISTM that the same effect could be achieved without
>> adding a new print function, but by setting more options (separator,
>> ...) and calling an existing print function. If so, I think it would
>> reduce the code size.
>
> Maybe, maybe not. removing PRINT_RAW you need to enhance PRINT_UNALIGNED to
> use one shot parameters and you have to teach it to print column names in
> tuples_only mode. The code's length will be same. The form of this patch is
> not final.
Hmmm. Ok. It depends on the change implication on the print unaligned
function.
--
Fabien.
From | Date | Subject | |
---|---|---|---|
Next Message | Torsten Zuehlsdorff | 2017-08-24 07:07:03 | Re: Thoughts on unit testing? |
Previous Message | Douglas Doole | 2017-08-24 05:51:41 | Re: [PATCH] Push limit to sort through a subquery |