From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: proposal: psql command \graw |
Date: | 2017-08-24 03:50:45 |
Message-ID: | alpine.DEB.2.20.1708240549050.1575@lancre |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello Pavel,
I have added the patch to the next commitfest.
Patch applies, compiles, works.
I'm okay with the names graw/graw+, and for having such short-hands.
Missing break in switch, even if last item and useless, because other
items do it... Also should be added at its place in alphabetical order?
"column_header" is somehow redundant with "tuples_only". Use the
existing one instead of adding a new one?
More generally, ISTM that the same effect could be achieved without
adding a new print function, but by setting more options (separator,
...) and calling an existing print function. If so, I think it would
reduce the code size.
Missing help entry.
Missing non regression tests.
Missing documentation.
--
Fabien.
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2017-08-24 04:35:32 | Re: proposal: psql command \graw |
Previous Message | Bossart, Nathan | 2017-08-24 03:38:10 | Re: [Proposal] Allow users to specify multiple tables in VACUUM commands |