Re: Confusing error message in pgbench

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, robertmhaas(at)gmail(dot)com, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Confusing error message in pgbench
Date: 2017-08-03 09:09:50
Message-ID: alpine.DEB.2.20.1708031101240.19721@lancre
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


>> Indeed. It doesn't look that hard: AFAICS the problem is just that
>> process_sql_command() is making premature decisions about whether to
>> extract parameters from the SQL commands. Proposed patch attached.
>
> Great. Patch looks good to me.

Too me as well: code looks ok, patch applies, compiles, make check
ok, manual tests with pgbench ok.

That is one more patch about pgbench in the queue.

--
Fabien.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-08-03 09:37:32 Re: Clarification in pg10's pgupgrade.html step 10 (upgrading standby servers)
Previous Message Jeevan Ladhe 2017-08-03 09:07:47 Re: INSERT ON CONFLICT and partitioned tables