Re: Confusing error message in pgbench

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us
Cc: robertmhaas(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Confusing error message in pgbench
Date: 2017-08-03 00:53:46
Message-ID: 20170803.095346.1795626841667325476.t-ishii@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

>> Not really objecting, but an even better fix might be to remove the
>> restriction on the order in which the options can be specified.
>
> Indeed. It doesn't look that hard: AFAICS the problem is just that
> process_sql_command() is making premature decisions about whether to
> extract parameters from the SQL commands. Proposed patch attached.

Great. Patch looks good to me.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2017-08-03 00:59:50 Re: BUG #14758: Segfault with logical replication on a function index
Previous Message Kyotaro HORIGUCHI 2017-08-03 00:30:57 Re: asynchronous execution