| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Victor Drobny <v(dot)drobny(at)postgrespro(dot)ru> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: merge psql ef/ev sf/sv handling functions |
| Date: | 2017-07-18 12:40:37 |
| Message-ID: | alpine.DEB.2.20.1707181436150.4496@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Victor,
>> While reviewing Corey's \if patch, I complained that there was some
>> amount of copy-paste in "psql/command.c".
>>
>> Here is an attempt at merging some functions which removes 160 lines of
>> code.
>
> I was looking through your patch. It seems good, the of the functions was
> very similar.
Indeed. I guess that it was initially a copy paste.
> I have a question for you. What was the reason to replace "printfPQExpBuffer"
> by "resetPQExpBuffer" and "appendPQExpBufferStr"?
Because the "printf" version implies interpreting the format layer which
does not add significant value compared to just appending the string.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo Nagata | 2017-07-18 12:49:27 | [PATCH] Make sure all statistics is sent after a few DML are performed |
| Previous Message | Alexey Chernyshov | 2017-07-18 12:18:25 | [PATCH] Add citext_pattern_ops to citext contrib module |