| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, Kevin Grittner <kgrittn(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: WIP Patch: Pgbench Serialization and deadlock errors |
| Date: | 2017-07-12 11:51:26 |
| Message-ID: | alpine.DEB.2.20.1707121338090.12795@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> LastBeginState -> RetryState? I'm not sure why this state is a pointer in
> CState. Putting the struct would avoid malloc/free cycles. Index "-1" may be
> used to tell it is not set if necessary.
Another detail I forgot about this point: there may be a memory leak on
variables copies, ISTM that the "variables" array is never freed.
I was not convinced by the overall memory management around variables to
begin with, and it is even less so with their new copy management. Maybe
having a clean "Variables" data structure could help improve the
situation.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sandeep Thakkar | 2017-07-12 12:19:09 | pl/perl extension fails on Windows |
| Previous Message | Alik Khilazhev | 2017-07-12 11:31:02 | Re: [WIP] Zipfian distribution in pgbench |