Re: proposal psql \gdesc

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal psql \gdesc
Date: 2017-05-20 20:26:08
Message-ID: alpine.DEB.2.20.1705202213070.6053@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Pavel,

>> - Maybe tests could also exercise unnamed columns, eg:
>> SELECT 1, 2, 3 \gdesc \g
>
> done

Can't see it. No big deal, but if you put it it did not get through, and
there is a warning with git apply on the very last line of the patch which
may be linked to that:

psql-gdesc-05.patch:328: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

... especially as the two last tests are nearly the same now. I'm fine
with a "one line" test, could be with some unnamed columns so that it is
more different?

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message MauMau 2017-05-20 21:15:13 [Q] When should I use reg* types instead of oid in the system catalog?
Previous Message Tom Lane 2017-05-20 19:56:01 Re: Regression in join selectivity estimations when using foreign keys