| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgbench tap tests & minor fixes |
| Date: | 2017-04-24 07:01:18 |
| Message-ID: | alpine.DEB.2.20.1704240859200.2912@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> To sum up:
>
> - I agree to add a generic command TestLib & a wrapper in PostgresNode,
> instead of having pgbench specific things in the later, then call
> them from pgbench test script.
>
> - I still think that moving the pgbench scripts inside the test script
> is a bad idea (tm).
Here is a v2 along those lines.
I have also separated some basic test which do not need a server running,
as done in other tap tests.
--
Fabien.
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-tap-2.patch | text/x-diff | 34.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2017-04-24 07:41:56 | Re: Interval for launching the table sync worker |
| Previous Message | Masahiko Sawada | 2017-04-24 05:55:05 | Re: Quorum commit for multiple synchronous replication. |