| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Erik Rijkers <er(at)xs4all(dot)nl>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, PostgreSQL <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |
| Date: | 2017-03-29 18:16:15 |
| Message-ID: | alpine.DEB.2.20.1703292000520.17210@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Tom,
> If someone were to put together a TAP test suite that covered all that
> and made for a meaningful improvement in psql's altogether-miserable
> code coverage report[1], I would think that that would be a useful
> expenditure of buildfarm time.
Ok, this is an interesting point.
> What I'm objecting to is paying the overhead for such a suite in order
> to test just this one thing.
Well, it should start somewhere. Once something is running it is easier to
add more tests.
> think that that passes the bang-for-buck test; or in other words, this
> isn't the place I would start if I were creating a TAP suite for psql.
Sure, I would not have started with that either.
Note that from this patch point of view, it is somehow logical to start
testing a given feature when this very feature is being developed...
The summary is that we agree that psql test coverage is abysmal, but you
do not want to bootstrap a better test infrastructure for this particular
and rather special new feature. Ok.
Maybe Corey can submit another patch with the exit 3 test removed.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2017-03-29 18:17:37 | Re: [PATCH] Reduce src/test/recovery verbosity |
| Previous Message | Jan Michálek | 2017-03-29 18:11:42 | Re: Other formats in pset like markdown, rst, mediawiki |