| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Verite <daniel(at)manitou-mail(dot)org>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Erik Rijkers <er(at)xs4all(dot)nl>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, PostgreSQL <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |
| Date: | 2017-03-27 14:34:24 |
| Message-ID: | alpine.DEB.2.20.1703271631250.10424@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
>> I think that you could use another pattern where you init the
>> PQExpBufferData structure instead of create it, so that only the string is
>> malloced.
>
> In v26, I have the functions return PQExpBuffer. The two calling functions
> then free it, which should solve any leak.
Yep, it works as well.
> Here's an addendum that does that. I can combine them in v27, but figured
> this was quicker.
It works.
However having just one full patch with a number would help so that I can
say "ready to committer" or not on something.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-03-27 14:38:05 | Re: rename pg_log directory? |
| Previous Message | Robert Haas | 2017-03-27 14:30:15 | Re: pg_dump emits ALTER TABLE ONLY partitioned_table |