| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)postgresql(dot)org, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] pgsql: Add missing support for new node fields |
| Date: | 2017-03-21 20:50:45 |
| Message-ID: | alpine.DEB.2.20.1703212146050.22754@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hello Andres,
>> It is not done yet, but it looks that it can work in the end with limited
>> effort. Currently it works for copy & equal.
>
> It'd have to do out/read as well imo.
Sure. This part is WIP, though.
>> Is there some interest to generate the x00kB of sources rather than edit
>> them everytime, or forgetting it from time to time, or does everyone like it
>> as it is?
>
> From my POV yes. But it's not quite as trivial as just generating it
> based on fields. Some fields are intentionally skipped, e.g. location,
> for equalfuncs, but not copy/out/readfuncs. So there needs to be a way
> to specify such special rules.
Indeed, I noticed these particularities... For some case it can be
automated with limited input. For really special cases (eg a few read/out
functions) , the script is told to skip some node types and the special
manual version is taken from the file instead of being generated.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2017-03-21 21:01:48 | Re: [COMMITTERS] pgsql: Add missing support for new node fields |
| Previous Message | Pavel Stehule | 2017-03-21 16:19:40 | Re: [COMMITTERS] pgsql: Add missing support for new node fields |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2017-03-21 21:01:48 | Re: [COMMITTERS] pgsql: Add missing support for new node fields |
| Previous Message | Denish Patel | 2017-03-21 20:43:30 | Re: Monitoring roles patch |