| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-committers(at)postgresql(dot)org, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add missing support for new node fields |
| Date: | 2017-03-21 06:22:57 |
| Message-ID: | alpine.DEB.2.20.1703210716370.22282@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
> Add missing support for new node fields
>
> Commit b6fb534f added two new node fields but neglected to add copy and
> comparison support for them, Mea culpa, should have checked for that.
I've been annoyed by these stupid functions and forgetting to update them
since I run into them while trying to fix an issue in pg_stat_statement
some time ago.
I've started to develop a perl script to generate most of them from
headers. It is not done yet, but it looks that it can work in the end with
limited effort. Currently it works for copy & equal.
Is there some interest to generate the x00kB of sources rather than edit
them everytime, or forgetting it from time to time, or does everyone like
it as it is?
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-03-21 06:28:50 | Re: [HACKERS] pgsql: Add missing support for new node fields |
| Previous Message | Bruce Momjian | 2017-03-21 02:33:35 | pgsql: doc: clarify that function "ownership" that controls permission |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-03-21 06:28:50 | Re: [HACKERS] pgsql: Add missing support for new node fields |
| Previous Message | Rushabh Lathia | 2017-03-21 06:06:00 | Re: Adding support for Default partition in partitioning |