| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | Greg Stark <stark(at)mit(dot)edu>, Erik Rijkers <er(at)xs4all(dot)nl>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, PostgreSQL <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |
| Date: | 2017-02-13 20:04:09 |
| Message-ID: | alpine.DEB.2.20.1702132053090.8071@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Corey,
> That effort was creating as many headaches as it solved. Rolled back v12
> except for doc paragraph, added more descriptive tap test names. Enjoy.
The TAP tests are missing from the patch, not sure why...
The stack cleanup is nicer with pop calls.
Two debatable suggestions about the example:
- put the on_error_stop as the very first thing in the example?
- add a comment explaining what the SELECT ... \gset does?
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-02-13 20:08:14 | Re: Removal of deprecated views pg_user, pg_group, pg_shadow |
| Previous Message | Pavel Stehule | 2017-02-13 19:59:43 | Re: possibility to specify template database for pg_regress |