| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | Daniel Verite <daniel(at)manitou-mail(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, PostgreSQL <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |
| Date: | 2017-02-07 21:06:27 |
| Message-ID: | alpine.DEB.2.20.1702072147030.13956@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> This was my previous understanding of ON_ERROR_STOP. Somewhere in the
> course of developing this patch I lost that. Glad to have it back.
>
> The only changes I made were to invalid booleans on if/elif, and the final
> branch balancing check won't set status to EXIT_USER unless it's
> non-interactive and ON_ERROR_STOP = on.
About v10: Patch applies, make check ok, psql tap test ok. Html doc
generation ok.
Everything looks ok to me.
Interactive tests behave as expected, especially ctrl-C and with
on_error_stop=1.
ISTM that everything has been addressed.
I've switched the patch to "Ready for Committers", let's what happens on
their side...
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2017-02-07 21:07:07 | Re: Press Release Draft - 2016-02-09 Cumulative Update |
| Previous Message | Robert Haas | 2017-02-07 21:03:43 | Re: Parallel bitmap heap scan |