Re: pgbench more operators & functions

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench more operators & functions
Date: 2017-01-25 10:28:00
Message-ID: alpine.DEB.2.20.1701250952570.29470@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Bonjour Michaël, Hello Robert,

>> Let's mark this Returned with Feedback and move on. We've only got a
>> week left in the CommitFest anyhow and there are lots of other things
>> that still need work (and which actually have been revised to match
>> previous feedback).
> Done as such, let's move on.


I think that there is a misunderstanding, most of which being my fault.

I have really tried to do everything that was required from committers,
including revising the patch to match all previous feedback.

Version 6 sent on Oct 4 did include all fixes required at the time (no if,
no unusual and operators, TAP tests)... However I forgot to remove some
documentation about the removed stuff, which made Robert think that I had
not done it. I apologise for this mistake and the subsequent

The current v8 sent on Jan 25 should only implement existing server-side
stuff, including with the same precedence as pointed out by Tom.

So for the implementation side I really think that I have done exactly all
that was required of me by committers, although sometimes with bugs or
errors, my apology, again...

As for the motivation, which is another argument, I cannot do more than
point to actual published official benchmark specifications that do
require these functions. I'm not inventing anything or providing some
useless catalog of math functions.

If pgbench is about being seated on a bench and running postgres on your
laptop to get some heat, my mistake... I thought it was about
benchmarking, which does imply a few extra capabities.

If the overall feedback is to be undestood as "the postgres community does
not think that pgbench should be able to be used to implement benchmarks
such as TPC-B", then obviously I will stop efforts to improve it for that

To conclude:

IMHO the relevant current status of the patch should be "Needs review" and
possibly "Move to next CF".

If the feedback is "we do not want pgbench to implement benchmarks such as
TPC-B", then indeed the proposed features are not needed and the status
should be "Rejected".

In any case, "Returned with feedback" does not really apply.



In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2017-01-25 10:29:44 Re: simplify sequence test
Previous Message Etsuro Fujita 2017-01-25 10:20:22 Re: Push down more UPDATEs/DELETEs in postgres_fdw