Re: pgbench more operators & functions

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench more operators & functions
Date: 2017-01-25 05:52:45
Message-ID: alpine.DEB.2.20.1701250638250.29470@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


>>> I'm spending time to try to make something useful of pgbench, which
>>> require a bunch of patches that work together to improve it for new
>>> use case, including not being limited to the current set of operators.
>>>
>>> This decision is both illogical and arbitrary.
>>
>> I disagree. I think his decision was probably based on this email from me:
>
> https://www.postgresql.org/message-id/CA+Tgmoa0zp4A+S+KosaV4QfDz-wA56vLpH8me86rmpsnkvWc2w@mail.gmail.com

> Nobody responded to that,

The answer is on the same day a direct reply that you can check here:

https://www.postgresql.org/message-id/alpine.DEB.2.20.1610041941150.24533%40lancre

The short version is: I have removed XOR and replaced "if" with the SQL
CASE syntax, and provided justification for the added operators in a
benchmarking context, i.e. some kind of test is necessary for TPC-B 2.0.0.
For conditions, logical expressions are needed. Bitwise operators are used
to skew distribution in some benchmarks (TPC-C as I recall). Functions
ln/exp could be used for the same purpose, but I can remove those two if
this is a blocker.

--
Fabien.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-01-25 05:53:20 Re: Pinning a buffer in TupleTableSlot is unnecessary
Previous Message Craig Ringer 2017-01-25 05:44:04 Re: [PATCH] Transaction traceability - txid_status(bigint)