Re: pgbench - allow backslash continuations in \set expressions

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench - allow backslash continuations in \set expressions
Date: 2017-01-13 15:45:36
Message-ID: alpine.DEB.2.20.1701131635560.32114@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


>> Could it be related to transformations operated when the file is downloaded
>> and saved, because it is a text file?
>
> I think this is delaying the patch unnecessarily, I have attached a
> version, please see if you can apply it successfully, we can proceed
> with that safely then...

This is the same file I sent:

sh> sha1sum pgbench-continuation-4.patch pgbench-continuation-3.patch
97fe805a89707565210699694467f9256ca02dab pgbench-continuation-4.patch
97fe805a89707565210699694467f9256ca02dab pgbench-continuation-3.patch

The difference is that your version is mime-typed with a generic

Application/OCTET-STREAM

While the one I sent was mime-typed as

text/x-diff

as defined by the system in /etc/mime.types on my xenial laptop.

My guess is that with the later your mail client changes the file when
saving it, because it sees "text".

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Verite 2017-01-13 15:51:39 Re: sequence data type
Previous Message Stephen Frost 2017-01-13 15:33:15 Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal