| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, craig(dot)ringer(at)2ndquadrant(dot)com, robertmhaas(at)gmail(dot)com, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BUG: pg_stat_statements query normalization issues with combined queries |
| Date: | 2017-01-12 19:08:54 |
| Message-ID: | alpine.DEB.2.20.1701122004190.3788@lancre |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
About having a pointer to the initial string from RawStmt, Query &
PlannedStmt:
> I remembered one reason why we haven't done this: it's unclear how we'd
> handle copying if we do it. If, say, Query contains a "char *" pointer
> then you'd expect copyObject() to pstrdup that string, [..., So] We'd
> need to work out a way of managing multiple Queries carrying references
> to the same source string, and it's not clear how to do that reasonably.
For me it would be shared, but then it may break some memory management
hypothesis downstream.
> So for now, it remains the path of least resistance for Portals and
> CachedPlans to contain a list of Query or PlannedStmt objects and a
> separate source string.
Ok. Thanks for the explanation.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Nasby | 2017-01-12 19:18:43 | Re: WARM and indirect indexes |
| Previous Message | Fabien COELHO | 2017-01-12 19:02:10 | Re: BUG: pg_stat_statements query normalization issues with combined queries |