|From:||Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>|
|To:||Heikki Linnakangas <hlinnaka(at)iki(dot)fi>|
|Cc:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: pgbench - minor fix for meta command only scripts|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
> Yeah, it really is quite a mess. I tried to review your patch, and I think
> it's correct, but I couldn't totally convince myself, because of the existing
> messiness of the logic.
> So I bit the bullet and started refactoring.
> I came up with the attached. It refactors the logic in doCustom() into a
> state machine.
Sounds good! This can only help.
> I think this is much clearer, what do you think?
I think that something was really needed. I'm going to review and test
this patch very carefully, probably over next week-end, and report.
|Next Message||Amit Kapila||2016-09-20 05:21:15||Re: WIP: Covering + unique indexes.|
|Previous Message||Ashish Tyagi||2016-09-20 04:47:46||Re: Improvements in psql hooks for variables|