Re: pgbench - minor fix for meta command only scripts

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench - minor fix for meta command only scripts
Date: 2016-07-11 05:10:07
Message-ID: alpine.DEB.2.20.1607110653460.12659@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Michaël,

> You may want to name your patches with .patch or .diff. Using .sql is
> disturbing style :)

Indeed! :-)

> Indeed, not reporting the progress back to the client in the case of a
> script with only meta commands is non-intuitive.
> This looks good to me. I'd just rewrite the comment block with
> something like that, more simplified:

Ok. Here is an updated version, with a better suffix and a simplified



Attachment Content-Type Size
pgbench-no-sql-fix-2.patch text/x-diff 524 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-07-11 05:13:11 Re: [COMMITTERS] Logical decoding
Previous Message Craig Ringer 2016-07-11 05:03:27 Re: [HACKERS] Logical decoding