Re: heap_sync seems rather oblivious to partitioned tables (wal_level=minimal)

From: Steve Singer <steve(at)ssinger(dot)info>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: heap_sync seems rather oblivious to partitioned tables (wal_level=minimal)
Date: 2018-11-02 02:43:00
Message-ID: alpine.DEB.2.11.1811012241440.3854@opti.atlantida
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 1 Nov 2018, David Rowley wrote:

>
> I ended up going with:
>
> However, this consideration only applies when
> <xref linkend="guc-wal-level"/> is <literal>minimal</literal> for
> non-partitioned tables as all commands must write WAL otherwise.
>

>
> I've changed this to:
>
> Rows will be frozen only if the table being loaded has been created
> or truncated in the current subtransaction, there are no cursors
> open and there are no older snapshots held by this transaction. It is
> currently not possible to perform a <command>COPY FREEZE</command> on
> a partitioned table.
>
> Which is just the original text with the new sentence tagged onto the end.
>
>> Other than that the patch looks fine and works as expected.
>>
>> The new status of this patch is: Waiting on Author
>
> Thanks for looking at this. I've attached an updated patch.

I am happy with the changes.
I think the patch is ready for a committer.

>
> --
> David Rowley http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Training & Services
>

Steve

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2018-11-02 02:46:59 Re: partitioned indexes and tablespaces
Previous Message Euler Taveira 2018-11-02 01:59:36 Re: row filtering for logical replication