Re: [HACKERS] pgbench regression test failure

From: Steve Singer <steve(at)ssinger(dot)info>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Steve Singer <steve(at)ssinger(dot)info>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] pgbench regression test failure
Date: 2017-11-15 03:00:51
Message-ID: alpine.DEB.2.11.1711142200180.29536@opti.atlantida
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 13 Nov 2017, Fabien COELHO wrote:

>
> Hello Steve,
>
>> printf("number of transactions actually processed: "
>> INT64_FORMAT "/%d\n",
>> - total->cnt - total->skipped, nxacts * nclients);
>> + total->cnt, nxacts * nclients);
>>
>> I think you want ntx instead of total->cnt here.
>
> Indeed... and this is also what my git branch contains... I just sent the
> wrong version, sorry:-( The same fix is also needed in the else branch.
>
> Here is the hopefully right version, which passes tests here.

This version seems fine.

I think it is ready for a committer

>
> --
> Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2017-11-15 03:12:32 Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.
Previous Message Amit Langote 2017-11-15 02:16:51 Re: [Sender Address Forgery]Re: [HACKERS] path toward faster partition pruning