Re: pgbench stats per script & other stuff

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench stats per script & other stuff
Date: 2016-03-28 07:32:59
Message-ID: alpine.DEB.2.10.1603280920070.16239@sto
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


> - that it does work:-) I'm not sure what happens by the script selection
> process, it should be checked carefully because it was not designed
> with allowing a zero weight, and it may depend on its/their positions.
> It may already work, but it really needs checking.

Hmmm, it seems ok.

Attached is an updated patch, which:

> - I would suggest that a warning is shown when a weight is zero,
> something like "warning, script #%d weight is zero, will be ignored".

includes such a warning.

> - the documentation should be updated:-)

adds a line about 0 weight in the documentation.

--
Fabien.

Attachment Content-Type Size
pgbench-zero-weight-2.patch text/x-diff 1.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien 2016-03-28 07:43:54 pgbench - show weight percent
Previous Message Peter Geoghegan 2016-03-28 07:21:54 Re: Draft release notes for next week's releases