| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: extend pgbench expressions with functions |
| Date: | 2016-02-10 15:37:13 |
| Message-ID: | alpine.DEB.2.10.1602101624010.14946@sto |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Michaël,
> + <replaceable>parameter</>% of the time.
> Nitpick: double space here.
Ok.
> + default:
> + return false;
> }
> In evalFunc(), the default case in switch for the operator functions
> should never be reached. Adding for example Assert(0) is something to
> consider.
Ok for Assert + a comment.
> PGBT_NONE and PGBENCH_NONE are used nowhere. Why not removing them
Ok.
v26 attached implements these changes.
--
Fabien.
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-funcs-26.patch | text/x-diff | 41.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2016-02-10 15:38:42 | Re: Updated backup APIs for non-exclusive backups |
| Previous Message | Artur Zakirov | 2016-02-10 15:34:11 | Re: Fuzzy substring searching with the pg_trgm extension |