Re: extend pgbench expressions with functions

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: extend pgbench expressions with functions
Date: 2016-02-11 13:32:41
Message-ID: CAB7nPqTpD=PCUWojNNf5rOY+84sP6QW+=p8vGj013w1=ccAD0A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 11, 2016 at 12:37 AM, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> v26 attached implements these changes.

+ /* the argument list has been built in reverse order, it is fixed here */
+ expr->u.function.args = reverse_elist(args);
Hm. I may be missing something, but why is that necessary? This is
basically doing a double-reversion to put all the arguments in the
correct order when parsing the function arguments.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mike Rylander 2016-02-11 13:35:30 Re: Fuzzy substring searching with the pg_trgm extension
Previous Message Jacek Wielemborek 2016-02-11 13:26:41 Re: Request for Code Review: BPGSQL