| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> | 
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> | 
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, bz(at)mailinator(dot)com, PostgreSQL Bugs List <pgsql-bugs(at)postgresql(dot)org> | 
| Subject: | Re: BUG #13442: ISBN doesn't always roundtrip with text | 
| Date: | 2015-07-28 07:57:12 | 
| Message-ID: | alpine.DEB.2.10.1507280946400.3538@sto | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-bugs | 
> AFAICS, that isn't exactly an improvement.  You're telling the user
> "if you have an ISBN column, you're screwed, and we are going to make it
> as painful as it can possibly be to get out of that situation".
>
> I think we'd be better off trying to migrate to a situation where these
> type names all still exist but they all act like ISBN13.  I'm not sure
> what the stages on that journey are.
Hmm... This is more or less what the previous version was doing, including 
display bugs.
So the attached v3:
  - distinguishes internally between ISBN & ISBN13 (so it is clean),
    but accepts values of one for the other transparently.
  - displays ISBN as ISBN if possible, otherwise they are show as
    ISBN13. This fixes the reported bug, and the application would
    have to adapt.
  - adds regression tests, including expected errors.
The good news is that there is no extension version update, it is just a 
behavioral change when ISBN13 numbers are used with the ISBN type.
-- 
Fabien.
| Attachment | Content-Type | Size | 
|---|---|---|
| isn-fix-3.patch | text/x-diff | 17.8 KB | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | dmitri.bourlatchkov | 2015-07-28 16:07:01 | BUG #13522: libtermcap.so: broken symbolic link to libncurses.so in PostgreSQL 9.4.4 binary distribution archive | 
| Previous Message | adfuser321 | 2015-07-28 07:56:29 | BUG #13521: refused connection to host and port |