Re: pgbench - allow backslash-continuations in custom scripts

From: Fabien COELHO <fabien(dot)coelho(at)mines-paristech(dot)fr>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, andres(at)anarazel(dot)de, hlinnaka(at)iki(dot)fi, josh(at)agliodbs(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgbench - allow backslash-continuations in custom scripts
Date: 2015-07-25 14:49:08
Message-ID: alpine.DEB.2.10.1507251637490.25082@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> Attatched is the revised version of this patch.
>
> The first patch is not changed from before.
>
> The second is fixed a kind of bug.
>
> Ths third is the new one to allow backslash continuation for
> backslash commands.

Ah, thanks:-)

Would you consider adding the patch to the next commitfest? I may put
myself as a reviewer...

> [...] I'm not satisfied by the design but I don't see another way..

I'll try to have a look.

>>> I don't have idea how to deal with the copy of psqlscan.[lh] from
>>> psql. Currently they are simply the dead copies of those of psql.
>>
>> I think that there should be no copies, but it should use relative
>> symbolic links so that the files are kept synchronized.
>
> Yeah, I think so but symlinks could harm on git and Windows.
> The another way would be make copies it from psql directory. They live
> next door to each other.

Indeed there are plenty of links already which are generated by makefiles
(see src/bin/pg_xlogdump/*), and probably a copy is made on windows. There
should no file duplication within the source tree.

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-07-25 14:50:05 Re: pg_dump -Fd and compression level
Previous Message Fabien COELHO 2015-07-25 14:35:11 Re: pgbench stats per script & other stuff