Re: pgbench stats per script & other stuff

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench stats per script & other stuff
Date: 2015-07-25 14:35:11
Message-ID: alpine.DEB.2.10.1507251618230.25082@sto
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


> Also, maybe per-command detailed stats should use the same common struct
> to hold data as all other stats. I did not change it because it is
> maintained in a different part of the code.

I played just once with the --report-latencies option and was astonished
that meta commands showed negative latencies...

This v5 also fixes this bug (on meta commands there is a goto loop in
doCustom, but as now was not reset the stmt_begin ended up being after
now, hence accumulating increasing negative times) and in passing uses the
same stats structure as the rest, which result in removing some more code.
The "report-latencies" option is made to imply per script stats, which
simplifies the final output code, and if you want per-command per-script
stats, probably providing the per-script stats, i.e. the sum of the
commands, make sense.

--
Fabien.

Attachment Content-Type Size
pgbench-script-stats-5.patch text/x-diff 55.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2015-07-25 14:49:08 Re: pgbench - allow backslash-continuations in custom scripts
Previous Message Michael Paquier 2015-07-25 14:09:59 Re: Anyone working on the TOAST items on the TODO list?