Re: Fix pgbench --progress report under (very) low rate

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix pgbench --progress report under (very) low rate
Date: 2015-06-15 18:12:54
Message-ID: alpine.DEB.2.10.1506152003240.26470@sto
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> v3 rebase (after pgbench moved to src/bin) and minor style tweaking.

v4 adds a fix to another progress timing issue:

Currently if pgbench/postgres get stuck somewhere, the report catches up
by repeating progresses several time in a row, which looks like that:

progress: 10.0 s ...
progress: 11.0 s ... stuck...
progress: 14.2 s catchup for 11.0 -> 14.2
progress: 14.2 s stupid data
progress: 14.2 s stupid data
progress: 15.0 s ...
progress: 16.0 s ...

The correction removes the "stupid data" lines which compute a reports on
a very short time, including absurd tps figures.

Yet again, shame on me in the first place for this behavior.

--
Fabien.

Attachment Content-Type Size
pgbench-sleeping-progress-4.patch text/x-diff 1.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message kjsteuer 2015-06-15 18:16:38 Re: Function to get size of notification queue?
Previous Message Brendan Jurd 2015-06-15 18:06:56 Re: Function to get size of notification queue?