Re: BUG #12379: pgbench should hint to pgbench -i

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: "Shulgin, Oleksandr" <oleksandr(dot)shulgin(at)zalando(dot)de>
Cc: mail <mail(at)bwe(dot)im>, PostgreSQL Bugs List <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #12379: pgbench should hint to pgbench -i
Date: 2015-05-21 11:33:34
Message-ID: alpine.DEB.2.10.1505211323240.14769@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs


>>>> HINT: is "foo" the right database? did you initialize first (pgbench -i)?

>>> Is "doo" the right database? Did you initialize it first (pgbench -i)?

>> HINT (pgbench): Is "foo" the right database? Did you initialize (-i) first?

>> pgbench: ...

>> pgbench HINT: ...

> Well, prefixing with "<binaryname>: " makes sense to me in the general
> case. But would it not be odd to do that for this message, and not the
> whole lot of the rest of stuff pgbench can print to stderr, which are not
> fatal errors, that is: hints?

Sure, it would not be strictly homogeneous with other stuff.

On the other hand, ISTM desirable that the "hint"ness quality of the
message is clear, because this is directly actionnable help, where other
messages just report a failure (cannot open log file, failed to set timer,
whatever), but do not provide much help for solving it, so I would rather
keep something with the "hint" word somewhere.

--
Fabien.

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Devrim Gündüz 2015-05-21 13:27:37 Re: unrecognized option '--help
Previous Message Shulgin, Oleksandr 2015-05-21 08:20:56 Re: BUG #12379: pgbench should hint to pgbench -i