Re: Enhancing pgbench parameter checking

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Enhancing pgbench parameter checking
Date: 2014-08-06 14:12:45
Message-ID: alpine.DEB.2.10.1408061559390.28413@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> Included is the patch to enhance the behavior of pgbench in this regard
> IMO. Here is a sample session after patching:
> $ ./pgbench -c 10 -T 300 -S -i test
> some parameters cannot be used in initialize mode

I have not tested, but the patch looks ok in principle.

I'm not sure of the variable name "is_non_init_parameter_set". I would
suggest "benchmarking_option_set"?

Also, to be consistent, maybe it should check that no
initialization-specific option are set when benchmarking.


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2014-08-06 14:38:44 Re: add modulo (%) operator to pgbench
Previous Message Fabien COELHO 2014-08-06 13:56:24 Re: A worst case for qsort