Re: ISN extension bug? (with patch)

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ISN extension bug? (with patch)
Date: 2014-01-03 17:53:49
Message-ID: alpine.DEB.2.10.1401031839340.7821@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

>> If so, there is only the one-liner patch to consider.
> This patch doesn't apply anymore. Please submit an updated patch for
> the commit fest.

In src/include/utils/elog.h there is an include for "utils/errcodes.h"
which is generated somehow when compiling postgresql but not present by
default. So you have to compile postgresql and then the contrib, or use
PGXS with an already installed version.

With this caveat, the one-liner patch (4 characters removed) reattached
does compile for me:

sh> git branch ismn2
sh> git checkout ismn2
sh> patch -p1 < ~/ismn-checksum.patch
patching file contrib/isn/isn.c
sh> ...
sh> cd contrib/isn
sh> make
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -fpic -I. -I. -I../../src/include -D_GNU_SOURCE -c -o isn.o isn.c
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -fpic -L../../src/port -L../../src/common -Wl,--as-needed -Wl,-rpath,'/usr/local/pgsql/lib',--enable-new-dtags -shared -o isn.o


Attachment Content-Type Size
ismn-checksum.patch text/x-diff 538 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Sergey Konoplev 2014-01-03 20:50:14 Re: Streaming replication bug in 9.3.2, "WAL contains references to invalid pages"
Previous Message Merlin Moncure 2014-01-03 17:22:46 Re: RFC: Async query processing