Re: review: pgbench progress report improvements

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: review: pgbench progress report improvements
Date: 2013-09-13 06:51:29
Message-ID: alpine.DEB.2.02.1309130846180.26803@localhost6.localdomain6
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello,

About patch eols:

>> postgresql> patch -p1 < ../pgbench-measurements-v2.patch
>> patching file contrib/pgbench/pgbench.c
>> patching file doc/src/sgml/pgbench.sgml
>
> it can depends on o.s. I did tests on Fedora 14. and for patching without
> warning I had to use dos2unix tool.

Hmmm. I use a Linux Ubuntu laptop, so generating DOS end of lines is
unlikely if it is not there at the beginning. Running "dos2unix" on the
patch file locally does not seem to change anything. So I assume that the
patch encoding was changed somewhere along the path you used to get it.

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Benedikt Grundmann 2013-09-13 07:03:17 Re: record identical operator
Previous Message Pavel Stehule 2013-09-13 04:50:56 Re: review: pgbench progress report improvements