Re: Add regression tests for ROLE (USER)

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Robins Tharakan <tharakan(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add regression tests for ROLE (USER)
Date: 2013-07-07 08:48:56
Message-ID: alpine.DEB.2.02.1307071046300.11644@localhost6.localdomain6
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> Generally, I think that the tests which return a syntax error are of
> limited value and should probably be dropped.

I think that it is not that simple: it is a good value to check that the
syntax error message conveys a useful information for the user, and that
changes to the parser rules do not alter good quality error messages.

Moreover, the cost of such tests in time must be quite minimal.

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Martijn van Oosterhout 2013-07-07 09:05:05 Re: How to implement Gin method?
Previous Message Sawada Masahiko 2013-07-07 07:27:37 Re: Patch for fail-back without fresh backup