| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Cédric Villemain <cedric(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Subject: | Re: [Review] Re: minor patch submission: CREATE CAST ... AS EXPLICIT |
| Date: | 2013-06-24 09:44:21 |
| Message-ID: | alpine.DEB.2.02.1306241140130.735@localhost6.localdomain6 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>> Here it is.
>
> The patch does not apply and git also whines about trailing space.
> It needs a v3...
The attachement here works for me.
Could you be more precise about the issue?
postgresql> git branch test master
postgresql> git checkout test
Switched to branch 'test'
postgresql> patch -p1 < ../as_explicit-v2.patch
patching file doc/src/sgml/ref/create_cast.sgml
patching file src/backend/parser/gram.y
patching file src/include/parser/kwlist.h
patching file src/test/regress/expected/create_cast.out
patching file src/test/regress/sql/create_cast.sql
> Please note that a community-agreed behavior on this patch is not yet
> acquired, you should consider that too.
Sure. I've sent my argumentation against Robert objections.
--
Fabien.
| Attachment | Content-Type | Size |
|---|---|---|
| as_explicit-v2.patch | text/x-diff | 6.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2013-06-24 10:08:35 | Re: [Review] Re: minor patch submission: CREATE CAST ... AS EXPLICIT |
| Previous Message | Kohei KaiGai | 2013-06-24 09:21:22 | Re: COPY and Volatile default expressions |