From: | Kris Jurka <books(at)ejurka(dot)com> |
---|---|
To: | Dave Cramer <pg(at)fastcrypt(dot)com> |
Cc: | Jonas Sundman <jonas(dot)sundman(at)thl(dot)fi>, "pgsql-jdbc(at)postgresql(dot)org" <pgsql-jdbc(at)postgresql(dot)org> |
Subject: | Re: bug on to do list reproducable at version 9.0-801 |
Date: | 2012-02-13 17:41:14 |
Message-ID: | alpine.BSO.2.00.1202131238460.21621@leary.csoft.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc |
On Mon, 13 Feb 2012, Dave Cramer wrote:
> Thanks for the patch. I've had some time to look at it. One problem I
> am running into is creating a test case for it.
>
> Currently all of our test code is in the test.org.postgresql....
> package(s) however I can't get access to one of the protected methods
> from there.
Are you confusing protected with package private? Changing the test
package won't magically give you access to a protected method.
> I'm thinking we should move all of the test code into
> org.postgresql.... package and drop the test. This would give us the
> ability to create unit tests on more methods
>
The easier approach is just to make more internal methods public. Since
everyone is really just dealing the standard java.sql interfaces, I don't
think we'd really be risking over-exposing driver internals.
Kris Jurka
From | Date | Subject | |
---|---|---|---|
Next Message | Florent Guillaume | 2012-02-13 17:59:45 | Re: bug on to do list reproducable at version 9.0-801 |
Previous Message | Kevin Grittner | 2012-02-13 17:32:23 | Re: bug on to do list reproducable at version 9.0-801 |