Re: Patch to fix bug #6293 - regression in driver performance with regards to ResultSetMetaData-heavy workloads

From: Kris Jurka <books(at)ejurka(dot)com>
To: Steven Schlansker <stevenschlansker(at)gmail(dot)com>
Cc: Till Toenges <tt(at)kyon(dot)de>, Dave Cramer <pg(at)fastcrypt(dot)com>, pgsql-jdbc(at)postgresql(dot)org
Subject: Re: Patch to fix bug #6293 - regression in driver performance with regards to ResultSetMetaData-heavy workloads
Date: 2012-02-10 09:09:11
Message-ID: alpine.BSO.2.00.1202100407320.8161@leary.csoft.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

On Thu, 9 Feb 2012, Steven Schlansker wrote:

> So IMO whether getMetaData() is thread safe or not is irrelevant, as
> nothing else in the class is. Making the entire class thread safe would
> probably not be worth the effort (sharing a ResultSet between threads
> just sounds like a bad idea, and the increased synchronization overhead
> would punish everyone who does it "right")

I concur that thread safety is not an issue here. I have committed a
variant of your fix that moves the caching into AbstractJdbc2ResultSet
instead of having each concrete implementation class have its own copy of
that code.

Kris Jurka

In response to

Browse pgsql-jdbc by date

  From Date Subject
Next Message Dave Cramer 2012-02-10 11:35:00 Re: GIT move
Previous Message th76 2012-02-10 08:56:28 Re: Patch to fix bug #6293 - regression in driver performance with regards to ResultSetMetaData-heavy workloads